From 5e7ed3807179ee8f0fb38c1c585f36e3149a3ceb Mon Sep 17 00:00:00 2001
From: Matthew Creal Morgan <matthew.c.morgan@census.gov>
Date: Thu, 4 Sep 2025 17:35:08 -0700
Subject: [PATCH] no region on provider (#18)

---
 dns-providers.tf |  2 --
 main.tf          | 24 ++++++++++++------------
 2 files changed, 12 insertions(+), 14 deletions(-)

diff --git a/dns-providers.tf b/dns-providers.tf
index ea2f427..20eec5a 100644
--- a/dns-providers.tf
+++ b/dns-providers.tf
@@ -3,7 +3,6 @@
 #-------------------------------------------------
 provider "aws" {
   alias   = "route53_main"
-  region  = var.region_map["east"]
   profile = var.profile
   assume_role {
     role_arn     = format("arn:%v:iam::%v:role/r-inf-terraform-route53", data.aws_arn.current.partition, var.route53_endpoints["route53_main"].account_id)
@@ -13,7 +12,6 @@ provider "aws" {
 
 provider "aws" {
   alias   = "route53_main_legacy"
-  region  = var.region_map["east"]
   profile = var.profile
   assume_role {
     role_arn     = format("arn:%v:iam::%v:role/r-inf-terraform-route53", data.aws_arn.current.partition, var.route53_endpoints["route53_main_legacy"].account_id)
diff --git a/main.tf b/main.tf
index 6c601e2..5617229 100644
--- a/main.tf
+++ b/main.tf
@@ -49,7 +49,7 @@ resource "aws_route53_vpc_association_authorization" "cluster_zone_east" {
 
   provider   = aws.self
   vpc_id     = data.aws_vpc.eks_vpc.id
-  vpc_region = "us-gov-east-1"
+  vpc_region = var.region_map["east"]
   zone_id    = aws_route53_zone.cluster_domain.zone_id
 }
 
@@ -58,7 +58,7 @@ resource "aws_route53_zone_association" "cluster_zone_east" {
 
   provider   = aws.route53_main
   vpc_id     = data.aws_vpc.eks_vpc.id
-  vpc_region = "us-gov-east-1"
+  vpc_region = var.region_map["east"]
   zone_id    = aws_route53_zone.cluster_domain.zone_id
 
   depends_on = [aws_route53_vpc_association_authorization.cluster_zone_east]
@@ -72,7 +72,7 @@ resource "aws_route53_vpc_association_authorization" "cluster_zone_west" {
 
   provider   = aws.self
   vpc_id     = data.aws_vpc.eks_vpc.id
-  vpc_region = "us-gov-west-1"
+  vpc_region = var.region_map["west"]
   zone_id    = aws_route53_zone.cluster_domain.zone_id
 }
 
@@ -81,7 +81,7 @@ resource "aws_route53_zone_association" "cluster_zone_west" {
 
   provider   = aws.route53_main
   vpc_id     = data.aws_vpc.eks_vpc.id
-  vpc_region = "us-gov-west-1"
+  vpc_region = var.region_map["west"]
   zone_id    = aws_route53_zone.cluster_domain.zone_id
 
   depends_on = [aws_route53_vpc_association_authorization.cluster_zone_west]
@@ -96,7 +96,7 @@ resource "aws_route53_vpc_association_authorization" "central_zone_east" {
 
   provider   = aws.self
   vpc_id     = var.route53_endpoints.route53_main["us-gov-east-1"]
-  vpc_region = "us-gov-east-1"
+  vpc_region = var.region_map["east"]
   zone_id    = aws_route53_zone.cluster_domain.zone_id
 }
 
@@ -105,7 +105,7 @@ resource "aws_route53_zone_association" "central_zone_east" {
 
   provider   = aws.route53_main
   vpc_id     = var.route53_endpoints.route53_main["us-gov-east-1"]
-  vpc_region = "us-gov-east-1"
+  vpc_region = var.region_map["east"]
   zone_id    = aws_route53_zone.cluster_domain.zone_id
 
   depends_on = [aws_route53_vpc_association_authorization.central_zone_east]
@@ -119,7 +119,7 @@ resource "aws_route53_vpc_association_authorization" "central_zone_west" {
 
   provider   = aws.self
   vpc_id     = var.route53_endpoints.route53_main["us-gov-west-1"]
-  vpc_region = "us-gov-west-1"
+  vpc_region = var.region_map["west"]
   zone_id    = aws_route53_zone.cluster_domain.zone_id
 }
 
@@ -128,7 +128,7 @@ resource "aws_route53_zone_association" "central_zone_west" {
 
   provider   = aws.route53_main
   vpc_id     = var.route53_endpoints.route53_main["us-gov-west-1"]
-  vpc_region = "us-gov-west-1"
+  vpc_region = var.region_map["west"]
   zone_id    = aws_route53_zone.cluster_domain.zone_id
 
   depends_on = [aws_route53_vpc_association_authorization.central_zone_west]
@@ -143,7 +143,7 @@ resource "aws_route53_vpc_association_authorization" "legacy_zone_east" {
 
   provider   = aws.self
   vpc_id     = var.route53_endpoints.route53_main_legacy["us-gov-east-1"]
-  vpc_region = "us-gov-east-1"
+  vpc_region = var.region_map["east"]
   zone_id    = aws_route53_zone.cluster_domain.zone_id
 }
 
@@ -152,7 +152,7 @@ resource "aws_route53_zone_association" "legacy_zone_east" {
 
   provider   = aws.route53_main_legacy
   vpc_id     = var.route53_endpoints.route53_main_legacy["us-gov-east-1"]
-  vpc_region = "us-gov-east-1"
+  vpc_region = var.region_map["east"]
   zone_id    = aws_route53_zone.cluster_domain.zone_id
 
   depends_on = [aws_route53_vpc_association_authorization.legacy_zone_east]
@@ -166,7 +166,7 @@ resource "aws_route53_vpc_association_authorization" "legacy_zone_west" {
 
   provider   = aws.self
   vpc_id     = var.route53_endpoints.route53_main_legacy["us-gov-west-1"]
-  vpc_region = "us-gov-west-1"
+  vpc_region = var.region_map["west"]
   zone_id    = aws_route53_zone.cluster_domain.zone_id
 }
 
@@ -175,7 +175,7 @@ resource "aws_route53_zone_association" "legacy_zone_west" {
 
   provider   = aws.route53_main_legacy
   vpc_id     = var.route53_endpoints.route53_main_legacy["us-gov-west-1"]
-  vpc_region = "us-gov-west-1"
+  vpc_region = var.region_map["west"]
   zone_id    = aws_route53_zone.cluster_domain.zone_id
 
   depends_on = [aws_route53_vpc_association_authorization.legacy_zone_west]