From 0cf9077079701ef6ebab3482a5aa77815b219bdb Mon Sep 17 00:00:00 2001 From: Dave Arnold Date: Thu, 23 Jul 2026 16:42:41 -0400 Subject: [PATCH] refactor: remove duplicate gh-auth/insteadOf steps, delegate to terraform-validate action - Action (CSVD/terraform-validate) now accepts github_app_pem_file and handles gh-auth + git config insteadOf internally - Remove inline Setup GITHUB Credentials + Configure Git HTTPS steps from workflow - Pass credentials directly to the action via 'with' inputs - Resolves CSVDIES-10490 --- .github/workflows/terraform-validate.yaml | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/.github/workflows/terraform-validate.yaml b/.github/workflows/terraform-validate.yaml index 326f217..fd397c8 100644 --- a/.github/workflows/terraform-validate.yaml +++ b/.github/workflows/terraform-validate.yaml @@ -13,19 +13,6 @@ jobs: - name: Checkout code uses: CSVD/gh-actions-checkout@v4 - - name: Setup GITHUB Credentials - id: github_credentials - uses: CSVD/gh-auth@main - with: - github_app_pem_file: ${{ secrets.GH_APP_PEM_FILE }} - github_app_installation_id: ${{ vars.GH_APP_INSTALLATION_ID }} - github_app_id: ${{ vars.GH_APP_ID }} - - - name: Configure Git HTTPS for Terraform module pulls - run: | - git config --global url."https://oauth2:${{ steps.github_credentials.outputs.github_token }}@github.e.it.census.gov/".insteadOf "git@github.e.it.census.gov:" - git config --global url."https://oauth2:${{ steps.github_credentials.outputs.github_token }}@github.e.it.census.gov/".insteadOf "ssh://git@github.e.it.census.gov/" - - name: Setup Terraform uses: CSVD/gh-actions-setup-terraform@v2 with: @@ -34,6 +21,10 @@ jobs: - name: Validate Terraform Configuration id: validate uses: CSVD/terraform-validate@main + with: + github_app_pem_file: ${{ secrets.GH_APP_PEM_FILE }} + github_app_installation_id: ${{ vars.GH_APP_INSTALLATION_ID }} + github_app_id: ${{ vars.GH_APP_ID }} - name: Check Validation/Test Results if: always()