From 38ffb1df8b659689f83bab35c3944be0c19fc96c Mon Sep 17 00:00:00 2001 From: Derryle Gogel Date: Thu, 3 Feb 2022 14:57:14 -0500 Subject: [PATCH 1/3] added ports for ServiceNow Discovery --- it-windows-base/ports.tf | 3 +++ 1 file changed, 3 insertions(+) diff --git a/it-windows-base/ports.tf b/it-windows-base/ports.tf index ba25b3c..62ae4b3 100644 --- a/it-windows-base/ports.tf +++ b/it-windows-base/ports.tf @@ -24,6 +24,7 @@ locals { n_ansible = ["172.24.12.239/32"] n_encase = ["148.129.121.72/32"] n_riverbed = ["172.24.100.107/32"] + n_servicenow = ["10.193.2.104/32", "10.193.2.104/32"] # n_hpsa = ["172.24.100.141/32", "172.24.100.154/32", "172.24.100.165/32"] # n_hpom = ["172.24.105.24/32"] source_groups = ["all", "external"] @@ -41,6 +42,8 @@ locals { # [1002, 1002, "tcp", "HPSA", local.n_hpsa, ["external"]], # [383, 383, "tcp", "HPOM", local.n_hpom, ["external"]], # [383, 383, "udp", "HPOM", local.n_hpom, ["external"]], + [135, 135, "tcp", "ServiceNow Discovery", local.n_servicenow, ["external"]], + [1024, 65535, "tcp", "ServiceNow Discovery", local.n_servicenow, ["external"]], ] # these are ignored From fcc90085c8729dc9cb575aa7ff3ce817e1a69e17 Mon Sep 17 00:00:00 2001 From: Derryle Gogel Date: Thu, 3 Feb 2022 15:20:37 -0500 Subject: [PATCH 2/3] Corrected duplicate entry --- it-windows-base/ports.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/it-windows-base/ports.tf b/it-windows-base/ports.tf index 62ae4b3..fb9f345 100644 --- a/it-windows-base/ports.tf +++ b/it-windows-base/ports.tf @@ -24,7 +24,7 @@ locals { n_ansible = ["172.24.12.239/32"] n_encase = ["148.129.121.72/32"] n_riverbed = ["172.24.100.107/32"] - n_servicenow = ["10.193.2.104/32", "10.193.2.104/32"] + n_servicenow = ["10.193.2.104/32", "10.193.3.207/32"] # n_hpsa = ["172.24.100.141/32", "172.24.100.154/32", "172.24.100.165/32"] # n_hpom = ["172.24.105.24/32"] source_groups = ["all", "external"] From 7068cb31e17b70f979007806b94b8bc565e29e71 Mon Sep 17 00:00:00 2001 From: Derryle Gogel Date: Thu, 3 Feb 2022 15:41:28 -0500 Subject: [PATCH 3/3] Updated version.tf, and CHANGELOG.md with change details --- it-windows-base/CHANGELOG.md | 3 +++ it-windows-base/version.tf | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/it-windows-base/CHANGELOG.md b/it-windows-base/CHANGELOG.md index e9e2e5e..0c93b6d 100644 --- a/it-windows-base/CHANGELOG.md +++ b/it-windows-base/CHANGELOG.md @@ -13,3 +13,6 @@ * remove HPSA and HPOM * ticket INC000002703111 +# v1.2.2 -- 20220203 + * Added 135 and 1024-65535/tcp to it-windows-base to allow discovery from csvdsnmidw001i.csp1.ead.census.gov, csvdsnmidw002i.csp1.ead.census.gov. + * ticket INC000002819140 diff --git a/it-windows-base/version.tf b/it-windows-base/version.tf index 54b3493..3472979 100644 --- a/it-windows-base/version.tf +++ b/it-windows-base/version.tf @@ -1,3 +1,3 @@ locals { - _module_version = "1.2.1" + _module_version = "1.2.2" }