From 58d454169ff670555b07c5393fbb67bd4e85fd81 Mon Sep 17 00:00:00 2001 From: badra001 Date: Mon, 21 Jun 2021 15:02:27 -0400 Subject: [PATCH] add description --- rds-oracle/CHANGELOG.md | 7 +++++-- rds-oracle/README.md | 5 +++++ rds-oracle/main.tf | 4 ++++ rds-oracle/ports.tf | 2 +- rds-oracle/variables.tf | 6 ++++++ rds-oracle/version.tf | 2 +- 6 files changed, 22 insertions(+), 4 deletions(-) diff --git a/rds-oracle/CHANGELOG.md b/rds-oracle/CHANGELOG.md index 167edf8..65bc294 100644 --- a/rds-oracle/CHANGELOG.md +++ b/rds-oracle/CHANGELOG.md @@ -1,5 +1,8 @@ -# v1.3 -- 20200604 +* v1.3 -- 20200604 - add module version, update tags -# v1.3.1 -- 20210621 +* v1.3.1 -- 20210621 - add ports 2483 and 2484 (tcp, tcp+ssl) + +* v1.3.2 -- 20210621 + - add variable description diff --git a/rds-oracle/README.md b/rds-oracle/README.md index 68a4079..166ad83 100644 --- a/rds-oracle/README.md +++ b/rds-oracle/README.md @@ -10,6 +10,10 @@ module "rds-oracle" { # name = "m-rds-oracle" vpc_id = var.vpc_id + + ## optional + # description = "my other description" # not recommended to change this + # Name, CostAllocation, and Environment are pre-set # tags = { } } @@ -41,6 +45,7 @@ No modules. | Name | Description | Type | Default | Required | |------|-------------|------|---------|:--------:| +| [description](#input\_description) | Security group description | `string` | `"module: Oracle common ports"` | no | | [egress\_networks](#input\_egress\_networks) | List of egress networks (all ports) | `list(string)` |
[
"0.0.0.0/0"
]
| no | | [name](#input\_name) | Security group Name | `string` | `"m-oracle-db"` | no | | [networks](#input\_networks) | List of ingress networks (applies to all ports) | `list(string)` |
[
"0.0.0.0/0"
]
| no | diff --git a/rds-oracle/main.tf b/rds-oracle/main.tf index f3fd981..39944cb 100644 --- a/rds-oracle/main.tf +++ b/rds-oracle/main.tf @@ -11,6 +11,10 @@ * * # name = "m-rds-oracle" * vpc_id = var.vpc_id +* +* ## optional +* # description = "my other description" # not recommended to change this +* * # Name, CostAllocation, and Environment are pre-set * # tags = { } * } diff --git a/rds-oracle/ports.tf b/rds-oracle/ports.tf index 87e8dca..3d5428a 100644 --- a/rds-oracle/ports.tf +++ b/rds-oracle/ports.tf @@ -1,5 +1,5 @@ locals { - description = "module: Oracle common ports" + description = var.description name = var.name ports = [ [1521, 1521, "tcp", "oracle-db", []], diff --git a/rds-oracle/variables.tf b/rds-oracle/variables.tf index 5824124..2f63f01 100644 --- a/rds-oracle/variables.tf +++ b/rds-oracle/variables.tf @@ -16,6 +16,12 @@ variable "name" { default = "m-oracle-db" } +variable "description" { + description = "Security group description" + type = string + default = "module: Oracle common ports" +} + variable "networks" { description = "List of ingress networks (applies to all ports)" type = list(string) diff --git a/rds-oracle/version.tf b/rds-oracle/version.tf index e4a1130..5ec2ece 100644 --- a/rds-oracle/version.tf +++ b/rds-oracle/version.tf @@ -1,3 +1,3 @@ locals { - _module_version = "1.3.1" + _module_version = "1.3.2" }