From 419b357f87e030ec1e598e2f8efacc6398621653 Mon Sep 17 00:00:00 2001
From: badra001 <donald.e.badrak.ii@census.gov>
Date: Tue, 5 Aug 2025 10:45:46 -0400
Subject: [PATCH] fix a zone_id

---
 CHANGELOG.md           | 3 +++
 a/entry.tf             | 2 +-
 a/main.tf              | 4 ++--
 common/ip_addresses.tf | 2 +-
 common/version.tf      | 2 +-
 5 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 094fe2a..679cbac 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -27,3 +27,6 @@
 
 * 1.2.2 -- 2025-06-10
   - host: fix entry.tf zone_id
+
+* 1.2.3 -- 2025-08-05
+  - a: fix entry.tf zone_id
diff --git a/a/entry.tf b/a/entry.tf
index 42515fc..a2b9d77 100644
--- a/a/entry.tf
+++ b/a/entry.tf
@@ -1,6 +1,6 @@
 resource "aws_route53_record" "entry" {
   count   = length(local.ipv4_hosts) > 0 ? 1 : 0
-  zone_id = var.zone_id != null ? data.aws_route53_zone.zone[0].zone_id : var.zone_id
+  zone_id = var.zone_id == null ? data.aws_route53_zone.zone[0].zone_id : var.zone_id
   name    = var.name
   type    = local.rr_type
   ttl     = var.ttl
diff --git a/a/main.tf b/a/main.tf
index d20c903..46c342d 100644
--- a/a/main.tf
+++ b/a/main.tf
@@ -126,7 +126,7 @@
 locals {
   record_type = "a"
   #  values      = [local.default_values[0]]
-  ipv4_hosts = [for h in local.default_values : h if length(regexall("\\.", h)) == 3 && ! can(regex("/", h))]
-  ipv6_hosts = [for h in local.default_values : h if length(regexall(":", h)) != 0 && ! can(regex("/", h))]
+  ipv4_hosts = [for h in local.default_values : h if length(regexall("\\.", h)) == 3 && !can(regex("/", h))]
+  ipv6_hosts = [for h in local.default_values : h if length(regexall(":", h)) != 0 && !can(regex("/", h))]
   values     = local.ipv4_hosts
 }
diff --git a/common/ip_addresses.tf b/common/ip_addresses.tf
index cb44922..f0146cb 100644
--- a/common/ip_addresses.tf
+++ b/common/ip_addresses.tf
@@ -2,6 +2,6 @@ locals {
   # Some ip ranges
   ip_ranges = []
 
-  ipv4_subnets = [for cidr in local.ip_ranges : cidr if ! can(regex("::", cidr))]
+  ipv4_subnets = [for cidr in local.ip_ranges : cidr if !can(regex("::", cidr))]
   ipv6_subnets = [for cidr in local.ip_ranges : cidr if can(regex("::", cidr))]
 }
diff --git a/common/version.tf b/common/version.tf
index 3472979..4e4bfa7 100644
--- a/common/version.tf
+++ b/common/version.tf
@@ -1,3 +1,3 @@
 locals {
-  _module_version = "1.2.2"
+  _module_version = "1.2.3"
 }