From 575c9dbfb568d3cd2e8be8d33f93dc69be9f2c62 Mon Sep 17 00:00:00 2001 From: badra001 Date: Fri, 24 Mar 2023 10:34:43 -0400 Subject: [PATCH] take [0] of values --- cname/README.md | 3 ++- cname/main.tf | 5 ++++- common/common.tf | 2 +- common/entry.tf | 2 +- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/cname/README.md b/cname/README.md index 9c84c7f..1482153 100644 --- a/cname/README.md +++ b/cname/README.md @@ -1,4 +1,5 @@ # About +A CNAME may contain only one entry, so if you pass multiple values (a list), it will only use the first one. # Usage ```hcl @@ -6,7 +7,7 @@ module "lakefront_cname" { source = "git@github.e.it.census.gov:terraform-modules/aws-dns//cname" name = format("%v.%v", local.app_shortname, var.vpc_domain_name) - values = [format("%v.execute-api.%v.amazonaws.com", data.aws_api_gateway_rest_api.lakefront.id, local.region)] + values = format("%v.execute-api.%v.amazonaws.com", data.aws_api_gateway_rest_api.lakefront.id, local.region) } ``` diff --git a/cname/main.tf b/cname/main.tf index 02ba4e8..1724fa6 100644 --- a/cname/main.tf +++ b/cname/main.tf @@ -1,5 +1,6 @@ /* aws-dns :: cname * # About +* A CNAME may contain only one entry, so if you pass multiple values (a list), it will only use the first one. * # Usage * * ```hcl @@ -7,11 +8,13 @@ * source = "git@github.e.it.census.gov:terraform-modules/aws-dns//cname" * * name = format("%v.%v", local.app_shortname, var.vpc_domain_name) -* values = [format("%v.execute-api.%v.amazonaws.com", data.aws_api_gateway_rest_api.lakefront.id, local.region)] +* values = format("%v.execute-api.%v.amazonaws.com", data.aws_api_gateway_rest_api.lakefront.id, local.region) * } * ``` +* */ locals { record_type = "cname" + values = [local.default_values[0]] } diff --git a/common/common.tf b/common/common.tf index 6c1cc84..b3c492a 100644 --- a/common/common.tf +++ b/common/common.tf @@ -17,7 +17,7 @@ locals { rr_type = upper(local.record_type) default_enable_ptr = lookup(local._defaults.enable_ptr, local.record_type, false) default_heritage_prefix = lookup(local._defaults.heritage_prefix, local.record_type, "") != "" ? format("%v.", lookup(local._defaults.heritage_prefix, local.record_type)) : "" - values = try([tostring(var.values)], tolist(var.values)) + default_values = try([tostring(var.values)], tolist(var.values)) } resource "time_static" "timestamp" {} diff --git a/common/entry.tf b/common/entry.tf index 771302f..322639f 100644 --- a/common/entry.tf +++ b/common/entry.tf @@ -3,5 +3,5 @@ resource "aws_route53_record" "entry" { name = var.name type = local.rr_type ttl = var.ttl - records = var.values + records = local.values }