Skip to content

Checking the TXT record before creating/updating/deleting A, PTR, and CNAME record #18

Open
cho00013 opened this issue Mar 11, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@cho00013
Copy link
Contributor

cho00013 commented Mar 11, 2022

build logic to check the TXT record BEFORE updating (create, update, delete) existing records. Currently the logic does not handle that.

From @badra001

I think an additional thing we need to put in place is a check on the heritage record.

If one exists for the resource, and it's heritage is different (NOT dynr53) we do not want to make the changes, and want to log that. This prevents something from creating their own record for something replacing something there. Like:

DNS
login.das.census.gov A some ip in cloud
TXT heritage/manual

Set up an instance as login.das.census.gov

Then it replaces the existing A record.

Ideally, we would include some sort of signature so that trying to fake it won't work. Like a JWT.

Probably need a bit more thought on this.

@cho00013 cho00013 added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Mar 11, 2022
@cho00013
Copy link
Contributor Author

That logic I think actually might be pretty extensive depending on how down the rabbit hole we want to go. I think one idea is to check the instance-id in the heritage record and ONLY create/update/delete it if it matches the instance-id that was in the event. I think that could a more straight-forward to safeguard the records.

@cho00013
Copy link
Contributor Author

Delete action now checks for the heritage value.

Sign in to join this conversation on GitHub.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants