From 0698e5c05c451798520c98b6902819c07a93887e Mon Sep 17 00:00:00 2001 From: badra001 Date: Fri, 16 Feb 2024 13:28:03 -0500 Subject: [PATCH] * 2.5.4 -- 2024-02-16 - terraform-state - a resource set to count=0 with no acl was failing; remove the resource (comment) --- CHANGELOG.md | 4 ++++ common/version.tf | 2 +- terraform-state/README.md | 1 - terraform-state/main.tf | 13 +++++++------ 4 files changed, 12 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2c0c330..7b49fe3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -342,3 +342,7 @@ * 2.5.3 -- 2024-02-09 - s3-config-org - update key policy, sns permissions to allow s3 -> sns -> sqs + +* 2.5.4 -- 2024-02-16 + - terraform-state + - a resource set to count=0 with no acl was failing; remove the resource (comment) diff --git a/common/version.tf b/common/version.tf index 84776d4..568abb4 100644 --- a/common/version.tf +++ b/common/version.tf @@ -1,3 +1,3 @@ locals { - _module_version = "2.5.3" + _module_version = "2.5.4" } diff --git a/terraform-state/README.md b/terraform-state/README.md index 791cd2b..3278b8b 100644 --- a/terraform-state/README.md +++ b/terraform-state/README.md @@ -217,7 +217,6 @@ No modules. | [aws_kms_alias.tfstate_key](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/kms_alias) | resource | | [aws_kms_key.tfstate_key](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/kms_key) | resource | | [aws_s3_bucket.tfstate](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket) | resource | -| [aws_s3_bucket_acl.tfstate](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_acl) | resource | | [aws_s3_bucket_ownership_controls.tfstate](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_ownership_controls) | resource | | [aws_s3_bucket_public_access_block.tfstate](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_public_access_block) | resource | | [aws_s3_bucket_server_side_encryption_configuration.tfstate](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_server_side_encryption_configuration) | resource | diff --git a/terraform-state/main.tf b/terraform-state/main.tf index 250b106..ed12ff3 100644 --- a/terraform-state/main.tf +++ b/terraform-state/main.tf @@ -165,12 +165,13 @@ resource "aws_s3_bucket_ownership_controls" "tfstate" { } } -resource "aws_s3_bucket_acl" "tfstate" { - # count = var.bucket_owner == "BucketOwnerEnforced" ? 0 : 1 - count = 0 - bucket = aws_s3_bucket.tfstate.id - # acl = "private" -} +# this is disabled but it's failing without acl. We will simply comment it for now +## resource "aws_s3_bucket_acl" "tfstate" { +## # count = var.bucket_owner == "BucketOwnerEnforced" ? 0 : 1 +## count = 0 +## bucket = aws_s3_bucket.tfstate.id +## # acl = "private" +## } #--- # kms