From 7bd7b0fdb68398694a345a596404f1125c2b8b93 Mon Sep 17 00:00:00 2001 From: badra001 Date: Wed, 13 Nov 2024 16:41:54 -0500 Subject: [PATCH] * 2.10.6 -- 2024-11-13 - vpc-interface-endpoint - fix route53 creation to base it off private_dns_name --- CHANGELOG.md | 4 ++++ common/version.tf | 2 +- vpc-interface-endpoint/route53.tf | 4 +++- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 14cd7ee..92a5efa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -418,3 +418,7 @@ * 2.10.5 -- 2024-11-13 - vpc-interface-endpoint - fix service vs service_name to better handle service name which are not short and non-regional (for new iam endpoint) + +* 2.10.6 -- 2024-11-13 + - vpc-interface-endpoint + - fix route53 creation to base it off private_dns_name diff --git a/common/version.tf b/common/version.tf index ba09d74..2003c74 100644 --- a/common/version.tf +++ b/common/version.tf @@ -1,5 +1,5 @@ locals { - _module_version = "2.10.5" + _module_version = "2.10.6" _module_names = { "_main_" = "aws-vpc-setup" diff --git a/vpc-interface-endpoint/route53.tf b/vpc-interface-endpoint/route53.tf index 2eb7bda..be6e869 100644 --- a/vpc-interface-endpoint/route53.tf +++ b/vpc-interface-endpoint/route53.tf @@ -13,8 +13,10 @@ locals { service_domain_parts = split(".", data.aws_vpc_endpoint_service.interface_endpoint.private_dns_name) is_wildcard = local.service_domain_parts[0] == "*" has_service = data.aws_vpc_endpoint_service.interface_endpoint.service != null + has_domain_name = data.aws_vpc_endpoint_service.interface_endpoint.private_dns_name != null domain_name = local.is_wildcard ? join(".", slice(local.service_domain_parts, 1, length(local.service_domain_parts))) : data.aws_vpc_endpoint_service.interface_endpoint.private_dns_name - r53_create = contains(local.permitted_accounts, local.account_id) && var.create_central_vpc_endpoint && length(local.domain_name) > 0 && local.has_service + # r53_create = contains(local.permitted_accounts, local.account_id) && var.create_central_vpc_endpoint && length(local.domain_name) > 0 && local.has_service + r53_create = contains(local.permitted_accounts, local.account_id) && var.create_central_vpc_endpoint && length(local.domain_name) > 0 && local.has_domain_name } resource "aws_route53_zone" "vpce" {