fix: patch4 module cleanup batch (10106/10107/10109/10110/10111) #2
+10
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0110/10111) CSVDIES-10106: convert module sources from SSH to HTTPS (roles.tf) CSVDIES-10107: add sts:AssumeRole on patch_execution_role to patch_execproxy_role policy CSVDIES-10109: remove dead TARGET_SQS_QUEUE_AUTOMATIONDOC_URL env var from dispatcher Lambda and Python source CSVDIES-10110: remove direct lambda.amazonaws.com principal from patch_role assume policy CSVDIES-10111: remove unused null provider from versions.tf CSVDIES-10108: dispatcher does not need the shared Lambda layer (no psycopg dependency)
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Batch of cleanup fixes for the
terraform-csvd-patch4module identified during CSVDIES-9999 provisioning work.Changes
sourceURLs inroles.tffrom SSH (git@) to HTTPS (git::https://)sts:AssumeRoleonpatch_execution_roletopatch_execproxy_rolepermissions policyTARGET_SQS_QUEUE_AUTOMATIONDOC_URLenv var from dispatcher Lambda (TF + Python)lambda.amazonaws.comprincipal frompatch_roleassume policynullprovider fromversions.tfFiles Changed
roles.tf— SSH to HTTPS module sourcespolicies.tf— execproxy role permission + removed rogue Lambda principal from patch_role assumelambda.tf— removed dead env varlambda-dispatcher/src/lambda_function.py— removed dispatch_type 3 from QUEUE_MAPversions.tf— removed null provider