Skip to content

Commit

Permalink
updating
Browse files Browse the repository at this point in the history
  • Loading branch information
Your Name committed Sep 16, 2025
1 parent 5e31ec1 commit e63bb01
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 16 deletions.
8 changes: 5 additions & 3 deletions docs/callnote-09152025-implementation.md
Original file line number Diff line number Diff line change
Expand Up @@ -607,14 +607,15 @@ module "github_repo" {
- [x] Create implementation plan
- [x] Begin Phase 1: Variable consolidation

### September 16, 2025 (Today - In Progress)
### September 16, 2025 (Today - COMPLETED)
- [x] **COMPLETED:** Create defaults.tf file with all module defaults
- [x] **COMPLETED:** Update variables.tf to remove redundant variables
- [x] **COMPLETED:** Update main.tf to pass local values to templates
- [x] **COMPLETED:** Fix locals.tf to use new simplified interface
- [x] **COMPLETED:** Fix validation errors and template variable references
- [x] **COMPLETED:** Update examples to use simplified interface
- [ ] **IN PROGRESS:** Begin Phase 2: Workspace creation with correct naming (eks-clusters-workspace)
- [x] **COMPLETED:** Terraform validation and initialization successful
- [ ] **READY FOR NEXT:** Begin Phase 2: Workspace creation (eks-clusters-workspace)
- [ ] **SCHEDULED:** Conduct dry run demo
- [ ] **PENDING:** Final testing and validation

Expand Down Expand Up @@ -666,7 +667,7 @@ module "github_repo" {
- Will demonstrate multi-cluster management without conflicts
- Includes examples from both David and Matthew's configurations

2. **Template Variable Handling - ARCHITECTURE DECISION MADE**
2. **Template Variable Handling - ARCHITECTURE DECISION IMPLEMENTED**
- Templates now properly receive variables instead of using hardcoded values
- All defaults defined in defaults.tf and passed via templatefile() calls
- This ensures generated configurations reflect computed values
Expand All @@ -677,6 +678,7 @@ module "github_repo" {
-**Terraform Init**: PASSED
-**Template Rendering**: WORKING
-**Variable References**: RESOLVED
-**Module Loading**: SUCCESSFUL

### 🏗️ Implementation Architecture

Expand Down
13 changes: 0 additions & 13 deletions examples/basic/main.tf
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
provider "aws" {
}

data "aws_secretsmanager_secret_version" "github_token" {
secret_id = "/eks-cluster-deployment/github_token"
}
Expand All @@ -17,10 +14,6 @@ module "eks_deployment" {
environment = "dev"
region = "us-gov-east-1"

# Basic settings
organization = "SCT-Engineering"
github_server_url = "https://github.e.it.census.gov"

# Cluster configuration - simplified interface
cluster_config = {
account_name = "csvd-dev-ew"
Expand All @@ -36,12 +29,6 @@ module "eks_deployment" {
}
organization = "census:ocio:csvd"
}

# Team permissions
repository_teams = {
"platform-team" = "admin"
"developers" = "push"
}
}

output "repository_url" {
Expand Down

0 comments on commit e63bb01

Please sign in to comment.