docs: ADR 0001 — all generated cluster repo files must be versioned in terraform-eks-deployment #18
+1,871
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rraform-eks-deployment
…oyment - Add all 20 eks-module terragrunt.hcl files to templates/eks-modules/; these are written verbatim (file()) into the generated repo under $env/$region/$vpc/$cluster/<module>/terragrunt.hcl - Wire templates/eks-modules/ into managed_extra_files via a fileset-based local (eks_module_files) merged with the existing rendered_files local - Set template_repo = null in both defaults.tf and main.tf; all generated repo content now flows exclusively through managed_extra_files with no GitHub template seeding - Rename templates/common-variables.hcl and templates/default-versions.hcl to *.hcl.tf.tpl to match the existing convention: .tf.tpl = parsed by templatefile(), eks-modules/*.hcl = written verbatim - Update locals.tf references for the renamed template files - Fix alignment formatting in examples/basic and examples/adsd-tools-dev
arnol377
pushed a commit
that referenced
this pull request
Apr 21, 2026
…es/eks-modules Remove the data.github_repository_file / data.github_tree approach that read cluster-level terragrunt files from the template-eks-cluster repo at runtime. All HCL templates are now managed locally in templates/eks-modules/ inside this module repo, consistent with the ADR merged in #18. Changes: - Remove effective_template_enabled_modules and template_cluster_sync_files locals - Remove data.github_repository_file.template_cluster_files data source - Remove template_repo_name, template_repo_ref, template_cluster_file_paths variables - Move effective_template_enabled_modules into the eks_module_files locals block and apply enablement filter directly to the fileset loop - Update desired_managed_files_by_path to use local.eks_module_files - Update template_enabled_modules variable description to reflect local template usage
arnol377
pushed a commit
that referenced
this pull request
Apr 21, 2026
* create new cluster to test * update defaults to min/desired 2 * make csvd-dev-mcm cluster for testing * add cluster for adsd-etdsb-tools-nonprod (#13) * rename cluster in convo with customer (#14) * Rename adsd tools (#15) * rename cluster in convo with customer * create cluster in csvd-common for testing * update cluster workflow * update environment_abbr based on account_name * add .gitignore for new clusters * update default-versions and common-variables gen * rename to match * fmt * self ref doesn't work * env fixed, add clusters folder * update to track files in template-eks-cluster/ * fix(finops_codes) ensure passed in finops codes are used * complete update workflow * update version for otel-collector-k8s * bump version of eks-dns and tempo * complete update workflow, fix create workflow, open PRs on both * remove cruft * more tags * update tags * update tag handling and gen * fix: replace local module path with CSVD GHE HTTPS source ref * fix: point module source to CSVD/terraform-github-repo main (feat/files-branch-source-branch merged) * refactor: replace template-eks-cluster remote sync with local templates/eks-modules Remove the data.github_repository_file / data.github_tree approach that read cluster-level terragrunt files from the template-eks-cluster repo at runtime. All HCL templates are now managed locally in templates/eks-modules/ inside this module repo, consistent with the ADR merged in #18. Changes: - Remove effective_template_enabled_modules and template_cluster_sync_files locals - Remove data.github_repository_file.template_cluster_files data source - Remove template_repo_name, template_repo_ref, template_cluster_file_paths variables - Move effective_template_enabled_modules into the eks_module_files locals block and apply enablement filter directly to the fileset loop - Update desired_managed_files_by_path to use local.eks_module_files - Update template_enabled_modules variable description to reflect local template usage --------- Co-authored-by: Dave Arnold <user@example.com>
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADR 0001
This PR adds an Architecture Decision Record documenting why all
eks-*/terragrunt.hcltemplate files must be committed interraform-eks-deployment/templates/eks-modules/rather than pulled live fromtemplate-eks-clusterat plan time.Key points
terraform-eks-deployment(REPO_BRANCH) must fully describe every file written into a generated cluster repo. Consistency cannot be guaranteed when files are split across two repos at independently-advancing refs.data.github_repository_fileapproach (PR Update Workflow for existing clusters #16) reads fromtemplate-eks-cluster:mainat plan time, which can diverge from the_envcommon/templates in this repo and silently produce internally inconsistent generated repos.template_repo) is not needed —CSVD/terraform-github-reponatively handles branch protection, CODEOWNERS, and team access.Related to PR #16 (
test_cluster).