flip eval target health to false

README.md

@@ -67,7 +67,6 @@ No modules.
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
 | <a name="input_cluster_name"></a> [cluster\_name](#input\_cluster\_name) | EKS cluster name name component used through out the EKS cluster describing its purpose (ex: dice-dev) | `string` | n/a | yes |
-| <a name="input_environment_abbr"></a> [environment\_abbr](#input\_environment\_abbr) | Environment abbreviation (ex: dev, prod) | `string` | `"lab"` | no |
 | <a name="input_istio_ingress_lb"></a> [istio\_ingress\_lb](#input\_istio\_ingress\_lb) | The istio ingress load balancer DNS. | `map(string)` | n/a | yes |
 | <a name="input_os_username"></a> [os\_username](#input\_os\_username) | OS username from environment variable, ideally as $USER | `string` | `null` | no |
 | <a name="input_profile"></a> [profile](#input\_profile) | AWS config profile | `string` | `""` | no |

main.tf

@@ -9,7 +9,6 @@ locals {
   is_shared_vpc              = data.aws_vpc.eks_vpc.owner_id != data.aws_caller_identity.current.account_id
   region                     = var.region
   vpc_domain_name            = var.vpc_domain_name
-  environment_abbr           = var.environment_abbr
 }
 
 #-------------------------------------------------
@@ -177,7 +176,7 @@ resource "aws_route53_record" "entry" {
   alias {
     name                   = var.istio_ingress_lb.dns_name
     zone_id                = var.istio_ingress_lb.zone_id
-    evaluate_target_health = true
+    evaluate_target_health = false # scaling actions will cause dns to drop otherwise
   }
 }
 

variables.tf

@@ -49,12 +49,6 @@ variable "os_username" {
   default     = null
 }
 
-variable "environment_abbr" {
-  description = "Environment abbreviation (ex: dev, prod)"
-  type        = string
-  default     = "lab"
-}
-
 ###################################################################
 # DNS variables
 ###################################################################