Feature dns ingress #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I uh... made some change. @mcgin314 LMK? |
|
Cool, we'll go with this based upon our chat earlier. Good stuff! |
|
I'd really like to use the CNAME module for this, so we do not have multiple implements of that code. What exact problem did you run into? |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the istio ingress nlb to input variables and uses to create the cname and heritage records in the dns zone. Definitely some copy and paste from the cname module, especially around the heritage record, but that has a data_source in the center that wasn't going to work for a plan.