Upgrade version 1.30 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to, especially since it is more likely to cause a conflict during upgrade.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily updates the module to latest EKS version 1.30. Additionally includes a handful of changes to move around some elements between subsequent modules, namely tfmod-eks-configuration. Generally think this should supersede the other branches and PRs.
Read the discussion in the other PR regarding provider configuration for creating cluster. Have been following the direction assuming the r-inf-terraform role using local configuration. Though, I think the desire was to code that directly in the module? Regardless, confirmed post cluster creation the access is working as anticipated. Will eventually sort out a specific TF role for EKS clusters instead of using the broader r-inf-terraform.
Additionally, created an example for adding additional cluster access using the new access entries construct. The example is currently commented out, but shows how to setup access using the new construct:
tfmod-eks/main.tf
Line 51 in 1971975