Skip to content

Cribl-based findings/remediations #45

Merged
merged 4 commits into from
Sep 5, 2025
Merged

Cribl-based findings/remediations #45

merged 4 commits into from
Sep 5, 2025

Conversation

morga471
Copy link
Contributor

  • add security groups and ports file for additional sg
  • add roles/policies.tf
  • refactor roles/policies.tf into cluster-admin and cluster-role

@morga471 morga471 requested review from andra315, yang0352, nangu001 and a team August 27, 2025 23:13
@morga471 morga471 self-assigned this Aug 27, 2025
@morga471 morga471 requested a review from arnol377 August 27, 2025 23:16
nangu001
nangu001 previously approved these changes Aug 28, 2025
Copy link
Collaborator

@nangu001 nangu001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@nangu001 nangu001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like refactor roltes.tf is failed, wanna take a look?

Copy link
Contributor

@arnol377 arnol377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nangu001 nangu001 self-requested a review September 5, 2025 17:43
Copy link
Collaborator

@nangu001 nangu001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nangu001 nangu001 merged commit 2dc2eda into main Sep 5, 2025
1 check passed
@nangu001 nangu001 deleted the mcm_sgs branch September 5, 2025 17:45
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
3 participants