Skip to content

🐛 fix(nodepool): reduce constraints on skew #12

Merged
merged 2 commits into from
Oct 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.6.0
rev: v5.0.0
hooks:
# Git style
- id: check-added-large-files
Expand Down Expand Up @@ -49,7 +49,7 @@ repos:

# Terraform Hooks
- repo: https://github.com/antonbabenko/pre-commit-terraform
rev: v1.92.1 # Get the latest from: https://github.com/antonbabenko/pre-commit-terraform/releases
rev: v1.96.1 # Get the latest from: https://github.com/antonbabenko/pre-commit-terraform/releases
hooks:
- id: terraform_fmt
args:
Expand Down Expand Up @@ -106,6 +106,6 @@ repos:
# - --hook-config=--parallelism-ci-cpu-cores=2

- repo: https://github.com/ljnsn/cz-conventional-gitmoji
rev: v0.3.2
rev: v0.6.1
hooks:
- id: conventional-gitmoji
62 changes: 31 additions & 31 deletions ec2_node_pool.yaml.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -31,37 +31,37 @@ spec:
group: karpenter.k8s.aws
kind: EC2NodeClass
name: ${cluster_name}-karpenter-node-class
kubelet:
containerRuntime: containerd
systemReserved:
cpu: 100m
memory: 100Mi
# kubelet:
# containerRuntime: containerd
# systemReserved:
# cpu: 100m
# memory: 100Mi
disruption:
consolidationPolicy: WhenEmptyOrUnderutilized
consolidateAfter: 0s
consolidateAfter: 5m
expireAfter: 72h
limits:
cpu: 1000
memory: 1000Gi
nvidia.com/gpu: 2
topologySpreadConstraints:
- maxSkew: 1
topologyKey: "topology.kubernetes.io/zone"
whenUnsatisfiable: ScheduleAnyway
- maxSkew: 1
topologyKey: "kubernetes.io/hostname"
whenUnsatisfiable: ScheduleAnyway
- maxSkew: 1
topologyKey: "karpenter.sh/capacity-type"
whenUnsatisfiable: ScheduleAnyway
budgets:
- nodes: "50%"
reasons:
- "Empty"
- "Drifted"
- nodes: "5"
- nodes: "0"
schedule: "@daily"
duration: 10m
reasons:
- "Underutilized"
# limits:
# cpu: 1000
# memory: 1000Gi
# nvidia.com/gpu: 2
# topologySpreadConstraints:
# - maxSkew: 99
# topologyKey: "topology.kubernetes.io/zone"
# whenUnsatisfiable: ScheduleAnyway
# - maxSkew: 99
# topologyKey: "kubernetes.io/hostname"
# whenUnsatisfiable: ScheduleAnyway
# - maxSkew: 99
# topologyKey: "karpenter.sh/capacity-type"
# whenUnsatisfiable: ScheduleAnyway
# budgets:
# - nodes: "50%"
# reasons:
# - "Empty"
# - "Drifted"
# - nodes: "5"
# - nodes: "0"
# schedule: "@daily"
# duration: 10m
# reasons:
# - "Underutilized"
6 changes: 5 additions & 1 deletion examples/simple/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,16 @@ terraform destroy
| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.5.0 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 5.14.0 |
| <a name="requirement_helm"></a> [helm](#requirement\_helm) | >= 2.11.0 |
| <a name="requirement_kubectl"></a> [kubectl](#requirement\_kubectl) | >= 1.14.0 |
| <a name="requirement_kubernetes"></a> [kubernetes](#requirement\_kubernetes) | >= 2.23.0 |

## Providers

| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | 5.57.0 |
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 5.14.0 |

## Modules

Expand Down
32 changes: 16 additions & 16 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -132,22 +132,22 @@ resource "helm_release" "karpenter" {
name = "controller.env[0].value"
value = var.region
}
set {
name = "resources.requests.cpu"
value = 1
}
set {
name = "resources.requests.memory"
value = "1Gi"
}
set {
name = "resources.limits.cpu"
value = 1
}
set {
name = "resources.limits.memory"
value = "1Gi"
}
# set {
# name = "resources.requests.cpu"
# value = 1
# }
# set {
# name = "resources.requests.memory"
# value = "1Gi"
# }
# set {
# name = "resources.limits.cpu"
# value = 1
# }
# set {
# name = "resources.limits.memory"
# value = "1Gi"
# }
set {
name = "serviceAccount.annotations.eks\\.amazonaws\\.com/role-arn"
value = module.karpenter_resources.iam_role_arn
Expand Down