🐛 fix(main.tf): fix service-linked-role creation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't delete |
|
The resource for the service-linked role for spot.amazonaws.com is an account level resource. This change will check if it exists, and create it if not. If it does exist, then we do not create it. |
|
I've had a bunch of issues with this. the service linked role shouldn't be a property of the cluster when it's account bound. |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
│ Error: creating IAM Service Linked Role (spot.amazonaws.com): operation error IAM: CreateServiceLinkedRole, https response error StatusCode: 400, RequestID: 30c6c648-6b6a-49fc-855b-949160fd6f7c, InvalidInput: Custom suffix is not allowed for spot.amazonaws.comresolves:
{"level":"ERROR","time":"2024-09-03T21:51:01.369Z","logger":"controller","message":"Reconciler error", "commit":"62a726c","controller":"nodeclaim.lifecycle","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","NodeClaim":{"name":"platform-eng-eks-mcm-node-pool-general-89qlw"}, "namespace":"","name":"platform-eng-eks-mcm-node-pool-general-89qlw","reconcileID":"fb79c654-2272-402e-9b43-1a85430a9705","error":"launching nodeclaim, creating instance, with fleet error(s), AuthFailure.ServiceLinkedRoleCreationNotPermitted: The provided credentials do not have permission to create the service-linked role for EC2 Spot Instances."}