Feature upgrade docs #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morga471
reviewed
Jul 23, 2024
Comment on lines
+1
to
+20
| provider "aws" { | ||
| profile = local.profile | ||
| region = local.region | ||
| } | ||
|
|
||
| provider "helm" { | ||
| kubernetes { | ||
| host = data.aws_eks_cluster.cluster.endpoint | ||
|
|
||
| cluster_ca_certificate = base64decode(data.aws_eks_cluster.cluster.certificate_authority[0].data) | ||
| token = data.aws_eks_cluster_auth.cluster.token | ||
| } | ||
| } | ||
|
|
||
| provider "kubernetes" { | ||
| host = data.aws_eks_cluster.cluster.endpoint | ||
|
|
||
| cluster_ca_certificate = base64decode(data.aws_eks_cluster.cluster.certificate_authority[0].data) | ||
| token = data.aws_eks_cluster_auth.cluster.token | ||
| } |
There was a problem hiding this comment.
if we are writing the sample for TG, then we should use provider generate in the terragrunt.hcl?
There was a problem hiding this comment.
I didn't really imagine ever trying the sample with Terragrunt. What I've been doing is testing each module just in pure Terraform with one of these examples and cover Terragrunt in another pass. I could be adding an additional step, but in my head I've wanted to be certain everything is right with the module in TF before introducing TG. If you think it's extra work, could save ourselves some time by skipping.
morga471
reviewed
Jul 23, 2024
Comment on lines
+31
to
+35
| region = "us-gov-east-1" | ||
| profile = "terraform" | ||
| cluster_name = "platform-test-1" | ||
| namespace = "prometheus" | ||
| create_namespace = "true" |
morga471
approved these changes
Jul 23, 2024
nangu001
approved these changes
Jul 23, 2024
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded all components, took a stab at documentation in the README, think this is in alignment with structure we want and created a simple example for local testing.