Skip to content
Jump to bottom

Move to kube-system namespace #10

Merged
merged 1 commit into from
Feb 27, 2025
+9 −5
Merged

Move to kube-system namespace #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 8 additions & 4 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,12 @@ resource "helm_release" "tempo" {
timeout = 300

set {
name = "tempo.storage.trace.s3.insecure"
value = "false"
name = "replicas"
value = "3"
}
set {
name = "tempo.replicas"
value = "2"
name = "tempo.storage.trace.s3.insecure"
value = "false"
}
set {
name = "tempo.repository"
Expand All @@ -72,6 +72,10 @@ resource "helm_release" "tempo" {
name = "tempo.storage.trace.s3.endpoint"
value = "s3.${var.region}.amazonaws.com"
}
set {
name = "tempo.metricsGenerator.enabled"
value = true
}
Comment on lines +75 to +78
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pattern wise - if we are setting a sstatic value, we should add it to the values.yml, if we are setting a dynamic value, we should use a --set block

set {
name = "tempo.metricsGenerator.remoteWriteUrl"
value = "http://${var.prometheus_svc}.${var.prometheus_namespace}:${var.prometheus_port}/api/v1/write"
Expand Down
2 changes: 1 addition & 1 deletion tempo_values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
---
tempo:
storage:
trace:
Expand All @@ -10,6 +9,7 @@ tempo:
value: "9411"
metricsGenerator:
enabled: true
remoteWriteUrl: http://prometheus-server.prometheus:80/api/v1/write
reportingEnabled: false

serviceAccount:
Expand Down