feat: migrate CSVD patch4 module code from CSVD/terraform-csvd-patch4 #1
+6,041
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
arnol377
commented
Jul 8, 2026
arnol377
commented
- Add full module implementation: kms, lambda, logs, outputs, policies, rds, roles, sqs, locals, variables
- Add lambda source code: dispatcher, worker, step-result, layer
- Add schema/patch40.sql
- Update data.tf with comprehensive VPC/SG/subnet lookups
- Update versions.tf to require terraform >= 1.0.0 and include archive provider
- Update variables.common.tf: remove duplicate 'tags' variable (now in variables.tf)
- Remove locals.tf.initial stub (replaced by real locals.tf)
added 7 commits
July 8, 2026 13:40
- Add full module implementation: kms, lambda, logs, outputs, policies, rds, roles, sqs, locals, variables - Add lambda source code: dispatcher, worker, step-result, layer - Add schema/patch40.sql - Update data.tf with comprehensive VPC/SG/subnet lookups - Update versions.tf to require terraform >= 1.0.0 and include archive provider - Update variables.common.tf: remove duplicate 'tags' variable (now in variables.tf) - Remove locals.tf.initial stub (replaced by real locals.tf)
- tags.tf: set legacy_tags = var.tags (replaces account/infra/app var merge) - locals.tf: replace manual finops_tags + base_tags with module.tags.tags and per-resource role via module.tags.finops_roles[role] - variables.tf: remove finops_project_name and finops_project_number variables (finops config now lives in tags.yml)
The aws-iam-role module prepends r- internally, so passing r-name resulted in r-r-name. Strip the prefix from patch_role_name, patch_execution_role_name, and patch_execproxy_role_name.
- locals.tf: all resource/log group name expressions - lambda.tf: path.module archive sources and layer source_path - sqs.tf: policy_id fields and owner ARN identifiers - policies.tf: all ARN constructions (iam, lambda, logs, rds-db) and org path - roles.tf: module source git@ format + role_description strings Also corrects roles.tf module sources from git::https:// to git@ per terraform-support naming convention.
worker: - replace unused RESULTS_QUEUE_URL with input_queue_url (sqs.delete_message) - add dbEndpoint, dbUsername, dbDatabase, dbRegion step_result: - add environment block with dbEndpoint, dbUsername, dbDatabase, dbRegion dispatcher unchanged (no DB access)
- Add patch_target_role_name variable (default: r-inf-patch) for the cross-account role name that must exist in each target account - Worker Lambda now passes aws_partition and patch_target_role_name as env vars alongside existing DB/queue vars - ec2.py builds the target ARN dynamically from env vars instead of hardcoding partition (aws-us-gov) and role name (r-inf-patch)
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.