Skip to content

Commit

Permalink
add description
Browse files Browse the repository at this point in the history
  • Loading branch information
badra001 committed Jun 21, 2021
1 parent 5c4eb25 commit 58d4541
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 4 deletions.
7 changes: 5 additions & 2 deletions rds-oracle/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# v1.3 -- 20200604
* v1.3 -- 20200604
- add module version, update tags

# v1.3.1 -- 20210621
* v1.3.1 -- 20210621
- add ports 2483 and 2484 (tcp, tcp+ssl)

* v1.3.2 -- 20210621
- add variable description
5 changes: 5 additions & 0 deletions rds-oracle/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ module "rds-oracle" {
# name = "m-rds-oracle"
vpc_id = var.vpc_id
## optional
# description = "my other description" # not recommended to change this
# Name, CostAllocation, and Environment are pre-set
# tags = { }
}
Expand Down Expand Up @@ -41,6 +45,7 @@ No modules.

| Name | Description | Type | Default | Required |
|------|-------------|------|---------|:--------:|
| <a name="input_description"></a> [description](#input\_description) | Security group description | `string` | `"module: Oracle common ports"` | no |
| <a name="input_egress_networks"></a> [egress\_networks](#input\_egress\_networks) | List of egress networks (all ports) | `list(string)` | <pre>[<br> "0.0.0.0/0"<br>]</pre> | no |
| <a name="input_name"></a> [name](#input\_name) | Security group Name | `string` | `"m-oracle-db"` | no |
| <a name="input_networks"></a> [networks](#input\_networks) | List of ingress networks (applies to all ports) | `list(string)` | <pre>[<br> "0.0.0.0/0"<br>]</pre> | no |
Expand Down
4 changes: 4 additions & 0 deletions rds-oracle/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
*
* # name = "m-rds-oracle"
* vpc_id = var.vpc_id
*
* ## optional
* # description = "my other description" # not recommended to change this
*
* # Name, CostAllocation, and Environment are pre-set
* # tags = { }
* }
Expand Down
2 changes: 1 addition & 1 deletion rds-oracle/ports.tf
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
locals {
description = "module: Oracle common ports"
description = var.description
name = var.name
ports = [
[1521, 1521, "tcp", "oracle-db", []],
Expand Down
6 changes: 6 additions & 0 deletions rds-oracle/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ variable "name" {
default = "m-oracle-db"
}

variable "description" {
description = "Security group description"
type = string
default = "module: Oracle common ports"
}

variable "networks" {
description = "List of ingress networks (applies to all ports)"
type = list(string)
Expand Down
2 changes: 1 addition & 1 deletion rds-oracle/version.tf
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
locals {
_module_version = "1.3.1"
_module_version = "1.3.2"
}

0 comments on commit 58d4541

Please sign in to comment.