update to output sg id and arn

terraform-modules · Jul 2, 2019 · af51403 · af51403
1 parent cf8d449
commit af51403
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 3 deletions.
diff --git a/ois-scanner/README.md b/ois-scanner/README.md
@@ -11,6 +11,7 @@ for the CAT environment, but we'll tackle that when we get to it.
 module "ois-scanner" {
   source = "git::https://vc1.csvd.census.gov/terraform-modules/aws-common-security-groups.git//ois-scanner"
 
+  # name = "ois-scanner"
   vpc_id = "${var.vpc_id}"
   # Name, CostAllocation, and Environment are pre-set
   # tags = { }
@@ -31,6 +32,14 @@ Type: `string`
 
 The following input variables are optional (have default values):
 
+### name
+
+Description: Security group Name
+
+Type: `string`
+
+Default: `"ois-scanner"`
+
 ### tags
 
 Description: Extra security group tags
@@ -39,3 +48,15 @@ Type: `map`
 
 Default: `<map>`
 
+## Outputs
+
+The following outputs are exported:
+
+### this\_security\_group\_arn
+
+Description: Created security group ARN
+
+### this\_security\_group\_id
+
+Description: Created security group ID
+
diff --git a/ois-scanner/main.tf b/ois-scanner/main.tf
@@ -52,8 +52,6 @@ resource "aws_security_group" "this_security_group" {
   }
 
   tags = "${merge(
-    map("CostAllocation", "csvd:infrastructure"),
-    map("Environment", "csvd-infrastructure"),
     map("Name", "sg-${var.name}"),
     var.tags,
     )}"

diff --git a/ois-scanner/outputs.tf b/ois-scanner/outputs.tf
diff --git a/ois-scanner/variables.tf b/ois-scanner/variables.tf
@@ -11,5 +11,8 @@ variable "tags" {
   description = "Extra security group tags"
 
   type    = "map"
-  default = { }
+  default = { 
+    "CostAllocation" = "csvd:infrastructure"
+    "Environment" = "csvd-infrastructure"
+  }
 }