Skip to content

added ports for ServiceNow Discovery #28

Merged
merged 3 commits into from
Feb 5, 2022
Merged

Conversation

gogel001
Copy link
Contributor

@gogel001 gogel001 commented Feb 3, 2022

Per Ian, and INC000002819140. I believe i have the correct update in place.

it-windows-base/ports.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@badra001 badra001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update;

  • CHANGELOG.md (add text for 1.2.2)
  • version.tf (change to 1.2.2)

Include in the changelog the two DNS names, IPs, reference ticket and any URL documentation (the stuff you shared with me)

Copy link
Contributor

@badra001 badra001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To apply this across the board will take some time. You will need to test this in one VPC first, and make sure access works. To do that:

cd account/vpc/region/vpc
tf-init -upgrade
tf-plan
# make sure it's only changing the thing you are expecting
# a target plan may be needed here
tf-apply

@badra001
Copy link
Contributor

badra001 commented Feb 5, 2022

Talk to me when it's in good shape and ready to be distributed everywhere.

@badra001 badra001 merged commit 032241e into master Feb 5, 2022
@badra001 badra001 deleted the servicenow-discovery branch February 5, 2022 12:47
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants