fix

terraform-modules · Apr 25, 2023 · 7b51451 · 7b51451
1 parent febebd3
commit 7b51451
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/code/ddns-lambda.py b/code/ddns-lambda.py
@@ -842,9 +842,9 @@ def lambda_handler(
             process_response = process_delete_records(
                 route53,
                 instance_id,
-                final_hosted_zone_id,
+                zone_data_forward.zone_id,
                 final_private_hostname,
-                final_hosted_zone_name,
+                zone_data_forward.name,
                 'A',
                 private_ip,
                 heritage_value
@@ -861,15 +861,11 @@ def lambda_handler(
             process_response = process_delete_records(
                 route53,
                 instance_id,
-                reverse_lookup_zone_id,
-                #            reversed_ip_address,
-                #            'in-addr.arpa.',
-                #                reversed_entry,
-                #                reversed_lookup_zone,
+                zone_data_reverse.zone_id,
                 tag_data['ptr_entry'].hostname,
                 tag_data['ptr_entry'].zonename,
                 'PTR',
-                final_private_dns_name,
+                create_fqdn(final_private_hostname, final_hosted_zone_name),
                 heritage_value
             )
             # only true if existing delete_records and the delete_success from the subroutine is true
@@ -906,7 +902,7 @@ def lambda_handler(
                     cname_host_name,
                     cname_domain_suffix,
                     'CNAME',
-                    final_private_dns_name
+                    create_fqdn(final_private_hostname, final_hosted_zone_name),
                 )
                 append_msg = f"CNAME record in zone id: {cname_domain_suffix_id} owner {phz_collection_by_vpc[cname_domain_suffix]['owner_account']} " + \
                     f"hostname {cname_host_name} in zone {cname_domain_suffix} with value {final_private_dns_name}"
@@ -964,7 +960,7 @@ def lambda_handler(
                 cname_host_name,
                 cname_domain_suffix,
                 'CNAME',
-                final_private_dns_name,
+                create_fqdn(final_private_hostname, final_hosted_zone_name),
                 heritage_value
             )