Skip to content

added heritage validation before delete and added 2 additional test events. #28

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

cho00013
Copy link
Contributor

At a high-level the following changes were made:

  1. Changed version to 0.3.0
  2. created a new def process_delete_record function to combine "repeating" tasks between A, PTR, and CNAME process. The code was combined with what was there before. Instead of doing the same process over 3 times, I just created a function and call it 3 times.
  3. The def process_delete_record function performs:
    1. checks TXT heritage validation (do I own it? does the instance ID match?)
    1. Also sends SNS notification if heritage validation fails.
    1. If not not pass validation, it skips deletion and sns notify
    1. If so, it deletes the records - (A, PTR, or CNAME and associated TXT)
  1. Fixed LOGGER.info lines that had a typo (missing parameter) in the sns notification caller. Example line 2274 but several others.
  2. Fixed lOGGER.info to convert MAX_API_RETRY to string when writing to log. Example line 2264 but several others.
  3. Updated new_get_resource_record with several fixes.
    1. Return "" instead of Non if not found -- better align with parent function that calls it.
    1. Checks the value of the list_resource_record_sets to match what should be returned. This is because the list_resource_record_sets API returns the next record (instead of matching exact) so wrong record can be retrieved if we do not check it.
    1. MaxItem value changed to string.
  1. Fixed def parse_heritage to add more logging and better input validation
  2. Fixed def get_heritage_item to check input type and add more logging.

@cho00013 cho00013 linked an issue Apr 18, 2022 that may be closed by this pull request
@cho00013 cho00013 requested a review from badra001 April 18, 2022 13:56
@cho00013
Copy link
Contributor Author

Also added 2 json test events... Minimum details needed to invoke the Lambda

Copy link
Contributor

@badra001 badra001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes, scan looks good. Will spit out new version and apply.

@badra001 badra001 merged commit 8d53d4b into master Apr 18, 2022
@badra001 badra001 deleted the heritage-validation branch April 18, 2022 20:18
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminating 50 instance generated ton of errors
2 participants