Skip to content

added Name field support - version 0.0.7 #9

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

cho00013
Copy link
Contributor

@cho00013 cho00013 commented Feb 7, 2022

Addressing the issue - #5

  1. Removed unneeded code and streamlined the logic to make it more stream-lined
  2. Added support for "Name" field as well a
  3. Added the comment at the top of the lambda function for high-level overview of the function.

Copy link
Contributor

@badra001 badra001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK
Hopefully the inclusion of ipaddress won't require different packaging of the zip file. I haven't tried it yet.

@cho00013
Copy link
Contributor Author

cho00013 commented Feb 7, 2022

OK
Hopefully the inclusion of ipaddress won't require different packaging of the zip file. I haven't tried it yet.

Yeah, I added that in my lab and did not see any additional required library or modules to be packaged in the Lambda, so it should be OK. Although I am not using the module. But I did wanted to add it so that we can use to make the code better.

@badra001 badra001 merged commit 5dad2f9 into master Feb 7, 2022
@badra001 badra001 deleted the awspeter_version007 branch February 7, 2022 19:01
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants