Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
  • Loading branch information
badra001 committed Nov 21, 2021
1 parent 2cad9bc commit 1894f8c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
3 changes: 1 addition & 2 deletions examples/full-cluster/cluster-roles/deployer-clusterrole.tf
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ resource "kubernetes_cluster_role" "cicd_deployer_istiosystem_cluster_role" {
rule {
api_groups = ["acme.cert-manager.io"]
resources = ["challenges", "orders", "certificaterequests"]

verbs = ["create", "delete", "deletecollection", "get", "list", "patch", "update", "patch"]
}

Expand All @@ -19,7 +18,6 @@ resource "kubernetes_cluster_role" "cicd_deployer_istiosystem_cluster_role" {

rule {
verbs = ["create", "delete", "deletecollection", "get", "list", "patch", "update", "patch"]

api_groups = ["networking.istio.io"]
resources = ["gateways"]
}
Expand Down Expand Up @@ -65,4 +63,5 @@ resource "kubernetes_cluster_role" "cicd_deployer_application_cluster_role" {
resources = ["certificates"]
verbs = ["create", "delete", "deletecollection", "get", "list", "patch", "update", "patch"]
}

}
4 changes: 2 additions & 2 deletions examples/full-cluster/cluster-roles/deployer.iam.tf
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
locals {
policy_cicd_k8s_group_name = replace(local.cicd_k8s_iam_username, local._prefixes["eks-user"], local._prefixes["eks-policy"])
role_cicd_k8s_group_name = replace(local.cicd_k8s_iam_username, local._prefixes["eks-user"],"")
role_cicd_k8s_group_name = replace(local.cicd_k8s_iam_username, local._prefixes["eks-user"], "")
iam_policies_cicd = ["p-inf-manage-access-keys"]
}

Expand Down Expand Up @@ -66,7 +66,7 @@ locals {
resources = ["*"]
}
ECRWrite = {
# effect = "Deny"
# effect = "Deny"
actions = [
"ecr:BatchDeleteImage",
"ecr:CompleteLayerUpload",
Expand Down
4 changes: 2 additions & 2 deletions examples/full-cluster/cluster-roles/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ variable "cicd_k8s_user_name" {
variable "cicd_k8s_group_name" {
description = "The Group name of CICD Deployer belongs to (excluding prefix for service account and cluster)"
type = string
default = "cicd-deployer"
default = "cicd-deployer"
}

variable "dba_k8s_user_name" {
Expand All @@ -41,7 +41,7 @@ variable "dba_k8s_user_name" {
variable "dba_k8s_group_name" {
description = "The Group name of dba-admin belongs to (excluding prefix for service account and cluster)"
type = string
default = "dba-admin"
default = "dba-admin"
}

variable "deployer_application_rolebinding_name" {
Expand Down

0 comments on commit 1894f8c

Please sign in to comment.