Obsoleted creation of cloudwatch log-group for the cluster

terraform-modules · Dec 14, 2023 · 423c84f · 423c84f
1 parent c61f3ba
commit 423c84f
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 22 deletions.
diff --git a/examples/full-cluster-tf-upgrade/1.25/main.tf b/examples/full-cluster-tf-upgrade/1.25/main.tf
@@ -50,17 +50,18 @@ locals {
 
 # The log group name format is /aws/eks/<cluster-name>/cluster
 # Reference: https://docs.aws.amazon.com/eks/latest/userguide/control-plane-logs.html
-resource "aws_cloudwatch_log_group" "eks_cluster" {
-  name              = format("/aws/eks/%v/cluster", var.cluster_name)
-  retention_in_days = 180
-
-  tags = merge(
-    local.base_tags,
-    local.common_tags,
-    var.tags,
-    var.application_tags,
-  )
-}
+# Obsolete: EKS cluster automatically creates the Cloudwatch log group
+#resource "aws_cloudwatch_log_group" "eks_cluster" {
+#  name              = format("/aws/eks/%v/cluster", var.cluster_name)
+#  retention_in_days = 180
+#
+#  tags = merge(
+#    local.base_tags,
+#    local.common_tags,
+#    var.tags,
+#    var.application_tags,
+#  )
+#}
 
 # we changed endpoint_public_access to false by default. This is so we can reach the EKS API through private IPs
 # from on-prem and from the cloud.  Otherwise, another account outside of where this is created will be unable to 

diff --git a/examples/full-cluster-tf-upgrade/1.28/main.tf b/examples/full-cluster-tf-upgrade/1.28/main.tf
@@ -50,17 +50,18 @@ locals {
 
 # The log group name format is /aws/eks/<cluster-name>/cluster
 # Reference: https://docs.aws.amazon.com/eks/latest/userguide/control-plane-logs.html
-resource "aws_cloudwatch_log_group" "eks_cluster" {
-  name              = format("/aws/eks/%v/cluster", var.cluster_name)
-  retention_in_days = 180
-
-  tags = merge(
-    local.base_tags,
-    local.common_tags,
-    var.tags,
-    var.application_tags,
-  )
-}
+# Obsolete: EKS cluster automatically creates the Cloudwatch log group
+#resource "aws_cloudwatch_log_group" "eks_cluster" {
+#  name              = format("/aws/eks/%v/cluster", var.cluster_name)
+#  retention_in_days = 180
+#
+#  tags = merge(
+#    local.base_tags,
+#    local.common_tags,
+#    var.tags,
+#    var.application_tags,
+#  )
+#}
 
 # we changed endpoint_public_access to false by default. This is so we can reach the EKS API through private IPs
 # from on-prem and from the cloud.  Otherwise, another account outside of where this is created will be unable to