Skip to content
Jump to bottom

Fixed common-service filtering correct images #12

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Fixed common-service filtering correct images #12

merged 4 commits into from
Oct 2, 2024

Conversation

dang0317
Copy link

@dang0317 dang0317 commented Oct 2, 2024

  • Resolved tech-debt in common-services and common-services/cluster-autoscaler not using the new images.yml as the source of truth to create ECR repos and upload images to them.
  • Fixed available latest version of cert-manager-ctl image

@dang0317
Copy link
Author

dang0317 commented Oct 2, 2024

I'm not sure if that's what dest_path is meant to be used for, as I don't see it used anywhere else. Thus I leveraged it for using as a filter key.

badra001
badra001 requested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@badra001 badra001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address comments please

badra001
badra001 requested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@badra001 badra001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more slight tweak to the readme please

badra001
badra001 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@badra001 badra001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@badra001 badra001 merged commit 9c6e7e6 into terraform-modules:tf-upgrade Oct 2, 2024
Sign in to join this conversation on GitHub.
Reviewers

@badra001 badra001 badra001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dang0317 @badra001