Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
badra001 committed Nov 26, 2021
1 parent 7ef9fb9 commit 6169822
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 14 deletions.
1 change: 0 additions & 1 deletion cloudtrail/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ No modules.
| Name | Type |
|------|------|
| [aws_cloudtrail.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudtrail) | resource |
| [aws_cloudwatch_log_group.cloudtrail](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudwatch_log_group) | resource |
| [aws_cloudwatch_log_group.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudwatch_log_group) | resource |
| [aws_iam_policy.cloudtrail_policy](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_policy) | resource |
| [aws_iam_role.cloudtrail](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role) | resource |
Expand Down
26 changes: 13 additions & 13 deletions cloudtrail/cloudtrail.tf
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ resource "aws_cloudtrail" "this" {
enable_logging = true
kms_key_id = var.kms_key_arn
sns_topic_name = var.enable_sns ? aws_sns_topic.cloudtrail[0].arn : null
cloud_watch_logs_group_arn = format("%v:*", aws_cloudwatch_log_group.cloudtrail.arn)
cloud_watch_logs_group_arn = format("%v:*", aws_cloudwatch_log_group.this.arn)
cloud_watch_logs_role_arn = aws_iam_role.cloudtrail.arn
is_organization_trail = var.enable_organization

Expand Down Expand Up @@ -70,15 +70,15 @@ data "aws_iam_policy_document" "cloudtrail_cloudwatch" {
}
}

resource "aws_cloudwatch_log_group" "cloudtrail" {
name = local.name

kms_key_id = var.kms_key_arn
retention_in_days = 7

tags = merge(
local.base_tags,
var.tags,
map("Name", format("%v-log", local.name)),
)
}
# resource "aws_cloudwatch_log_group" "cloudtrail" {
# name = local.name
#
# kms_key_id = var.kms_key_arn
# retention_in_days = 7
#
# tags = merge(
# local.base_tags,
# var.tags,
# map("Name", format("%v-log", local.name)),
# )
# }

0 comments on commit 6169822

Please sign in to comment.