remove null resource, make dir in script

terraform-modules · Apr 1, 2021 · f57530f · f57530f
1 parent b748097
commit f57530f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 16 deletions.
diff --git a/iam-saml/README.md b/iam-saml/README.md
@@ -40,7 +40,6 @@ No requirements.
 |------|---------|
 | <a name="provider_aws"></a> [aws](#provider\_aws) | n/a |
 | <a name="provider_external"></a> [external](#provider\_external) | n/a |
-| <a name="provider_null"></a> [null](#provider\_null) | n/a |
 
 ## Modules
 
@@ -51,7 +50,6 @@ No modules.
 | Name | Type |
 |------|------|
 | [aws_iam_saml_provider.saml](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_saml_provider) | resource |
-| [null_resource.saml_metadata](https://registry.terraform.io/providers/hashicorp/null/latest/docs/resources/resource) | resource |
 | [aws_arn.current](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/arn) | data source |
 | [aws_caller_identity.current](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/caller_identity) | data source |
 | [aws_iam_policy_document.saml_assume](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/iam_policy_document) | data source |

diff --git a/iam-saml/main.tf b/iam-saml/main.tf
@@ -47,19 +47,19 @@ locals {
   }
 }
 
-resource "null_resource" "saml_metadata" {
-  provisioner "local-exec" {
-    command = "test -d ${path.root}/setup || mkdir ${path.root}/setup"
-  }
-  # 
-  #   provisioner "local-exec" {
-  #     command = "bash ${path.module}/bin/get-saml-metadata.sh > ${path.root}/setup/metadata.xml"
-  #     environment = {
-  #       #      AWS_ENVIRONMENT = var.aws_environment
-  #       AWS_ENVIRONMENT = local.account_environment
-  #     }
-  #   }
-}
+## resource "null_resource" "saml_metadata" {
+##   provisioner "local-exec" {
+##     command = "test -d ${path.root}/setup || mkdir ${path.root}/setup"
+##   }
+##  
+##   provisioner "local-exec" {
+##     command = "bash ${path.module}/bin/get-saml-metadata.sh > ${path.root}/setup/metadata.xml"
+##     environment = {
+##       #      AWS_ENVIRONMENT = var.aws_environment
+##       AWS_ENVIRONMENT = local.account_environment
+##     }
+##   }
+## }
 
 data "external" "saml_metadata" {
   program = ["bash", "${path.module}/bin/external_get-saml-metadata.sh"]
@@ -69,7 +69,7 @@ data "external" "saml_metadata" {
     "output_file"     = local.saml_metadata_file
     #    "url_prefix" = ""
   }
-  depends_on = [null_resource.saml_metadata]
+  #  depends_on = [null_resource.saml_metadata]
 }
 
 resource "aws_iam_saml_provider" "saml" {