fix logging prefix

terraform-modules · Sep 24, 2020 · 712b61d · 712b61d
1 parent 70aa3c6
commit 712b61d
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/main.tf b/main.tf
@@ -52,7 +52,8 @@ resource "aws_s3_bucket" "this" {
 
   logging {
     target_bucket = var.access_log_bucket
-    target_prefix = format("%s/%s/", var.access_log_bucket_prefix, var.access_log_bucket)
+    target_prefix = format("%s/%s/", var.access_log_bucket_prefix, var.bucket_name)
+    #target_prefix = format("%s/%s/", var.access_log_bucket_prefix, var.access_log_bucket)
   }
 
   lifecycle {
@@ -99,9 +100,11 @@ data "aws_iam_policy_document" "this" {
   }
   statement  { 
     sid         = "enforceSSL"
-    effe        = "Deny"
-    principals  =  "*"
-    actions     = "s3:*"
+    effect      = "Deny"
+    actions     = ["s3:*"]
+    principals {
+      type        =  "AWS"
+      identifiers =  ["*"]
     resources   = [aws_s3_bucket.this.arn, "${aws_s3_bucket.this.arn}/*"]
     condition {
          test     = "Bool"
@@ -180,4 +183,4 @@ resource "aws_kms_alias" "key" {
   name          = "alias/${local.kms_key_name}"
   target_key_id = aws_kms_key.key.key_id
 }
-
+}