- ignore common/README.md

- do not create aws_s3_bucket_acl if bucket_owner is enforced
terraform-modules · Mar 25, 2022 · dd128b6 · dd128b6
1 parent 88e5b1c
commit dd128b6
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -97,3 +97,7 @@ This works with the Terraform AWS provider 4.x, released 2022-02.
 * 3.0.1 -- 2022-03-24
   - kms_key
     - wrap aws_kms_key resouce in try()
+
+* 3.0.2 -- 2022-03-25
+  - common/resource.tf
+    - do not create aws_s3_bucket_acl if bucket_owner is set to enforced
diff --git a/common/.gitignore b/common/.gitignore
@@ -0,0 +1 @@
+README.md
diff --git a/common/resources.tf b/common/resources.tf
@@ -268,8 +268,10 @@ data "template_file" "policy" {
 
 #---
 # s3 bucket refactor: acl
+#  if bucket_owner == BucketOwnerEnforced, ACLs cannot be set to private, so do not use this
 #---
 resource "aws_s3_bucket_acl" "this" {
+  count  = var.bucket_owner == "BucketOwnerEnforced" ? 0 : 1
   bucket = aws_s3_bucket.this.id
   acl    = "private"
 }

diff --git a/common/version.tf b/common/version.tf
@@ -1,3 +1,3 @@
 locals {
-  _module_version = "3.0.1"
+  _module_version = "3.0.2"
 }