add access-logging #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badra001
requested changes
Jul 29, 2020
main.tf
Outdated
| @@ -24,6 +24,11 @@ resource "aws_s3_bucket" "this" { | |||
| enabled = true | |||
| } | |||
|
|
|||
| logging { | |||
| target_bucket = var.access_log_bucket | |||
| target_prefix = "s3/{var.bucket_name}/" | |||
There was a problem hiding this comment.
Let's make this in to a variable, but with a default. Add to variables.tf
variable "access_log_bucket_prefix" {
description = "Access log bucket prefix, to which the bucket name will be appended to make the target_prefix"
type = string
default = "s3"
}and then change this line to
target_prefix = format("%s/%s/",var.access_log_bucket_prefix,var.access_log_bucket)
|
Added access log bucket prefix variable to vsriables.tf and updated target_prefix in main.tf as requested. |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "logging" bloc to main.tf