Skip to content

Commit

Permalink
update statemetns to chec for create first
Browse files Browse the repository at this point in the history
  • Loading branch information
badra001 committed May 25, 2022
1 parent 784a92e commit 75abdc3
Show file tree
Hide file tree
Showing 5 changed files with 32 additions and 23 deletions.
24 changes: 24 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# aws-security-audit

## version 1.x

* 1.0.0 tag initial release

## version 2.x

* 2.0.0 terraform 0.12 support

* 2.0.1 add contact, reference

* 2.1.0 -- 20210429
- add additional_policies feature
- add pre-commit hooks

* 2.1.1 -- 20210614
- add terraform tags

* 2.1.2 -- 20210614
- change to attach policies ia for_each

* 2.1.3 -- 2022-05-25
- update statements to check for create first
15 changes: 0 additions & 15 deletions CHANGES.md

This file was deleted.

6 changes: 3 additions & 3 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,8 @@ resource "aws_iam_access_key" "audit" {
resource "null_resource" "audit_output" {
count = length(var.users)
triggers = {
user = element(aws_iam_user.audit[*].name, count.index)
aws_access_key_id = element(local.aws_access_key_id, count.index)
aws_secret_access_key = element(local.aws_secret_access_key, count.index)
user = var.create_access_keys ? element(aws_iam_user.audit[*].name, count.index) : null
aws_access_key_id = var.create_access_keys ? element(local.aws_access_key_id, count.index) : null
aws_secret_access_key = var.create_access_keys ? element(local.aws_secret_access_key, count.index) : null
}
}
8 changes: 4 additions & 4 deletions outputs.tf
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
output "user" {
description = "Users created"
value = aws_iam_user.audit[*].name
value = var.create_access_keys ? aws_iam_user.audit[*].name : []
}

output "aws_access_key_id" {
description = "Access Key IDs for Users"
value = aws_iam_access_key.audit[*].id
value = var.create_access_keys ? aws_iam_access_key.audit[*].id : []
}

locals {
Expand All @@ -19,10 +19,10 @@ locals {
output "aws_secret_access_key" {
description = "Access Secret Key IDs for Users"
# value = [split(",", local.secret)]
value = aws_iam_access_key.audit[*].encrypted_secret
value = var.create_access_keys ? aws_iam_access_key.audit[*].encrypted_secret : []
}

output "aws_info" {
description = "Access key, secret, and user map output"
value = null_resource.audit_output[*].triggers
value = var.create_access_keys ? null_resource.audit_output[*].triggers : {}
}
2 changes: 1 addition & 1 deletion version.tf
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
locals {
_module_version = "2.1.2"
_module_version = "2.1.3"
}

0 comments on commit 75abdc3

Please sign in to comment.