Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
badra001 committed Sep 21, 2023
1 parent 5d259d2 commit 3a28b70
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
1 change: 0 additions & 1 deletion group-assignment/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ No modules.
| [aws_organizations_organizational_unit_descendant_accounts.accounts](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/organizations_organizational_unit_descendant_accounts) | data source |
| [aws_organizations_organizational_unit_descendant_accounts.ou](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/organizations_organizational_unit_descendant_accounts) | data source |
| [aws_region.current](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/region) | data source |
| [aws_ssoadmin_permission_set.pset](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/ssoadmin_permission_set) | data source |
| [ldap_object.users](https://registry.terraform.io/providers/trevex/ldap/latest/docs/data-sources/object) | data source |

## Inputs
Expand Down
27 changes: 14 additions & 13 deletions group-assignment/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ locals {
name = coalesce(var.name, try(local.settings.group, null))
description = coalesce(var.description, try(local.settings.description, null), local.name)
permissionset_name = coalesce(var.permissionset_name, try(local.settings.group, null), local.name)
permissionset_arn = coalesce(var.permissionset_arn, try(data.aws_ssoadmin_permission_set.pset[0].arn, null))
# permissionset_arn = coalesce(var.permissionset_arn, try(data.aws_ssoadmin_permission_set.pset[0].arn, null))
permissionset_arn = var.permissionset_arn
}

resource "aws_identitystore_group" "group" {
Expand Down Expand Up @@ -43,15 +44,15 @@ resource "aws_ssoadmin_account_assignment" "accounts" {
}
}

data "aws_ssoadmin_permission_set" "pset" {
count = var.permissionset_arn ? 1 : 0
instance_arn = var.instance_arn
name = local.permissionset_name

lifecycle {
precondition {
condition = local.permissionset_arn != null
error_message = "The permissionset name must be present."
}
}
}
# data "aws_ssoadmin_permission_set" "pset" {
# count = var.permissionset_arn == null ? 1 : 0
# instance_arn = var.instance_arn
# name = local.permissionset_name
#
# lifecycle {
# precondition {
# condition = local.permissionset_arn != null
# error_message = "The permissionset name must be present."
# }
# }
# }

0 comments on commit 3a28b70

Please sign in to comment.