Skip to content

Commit

Permalink
- subnets:
Browse files Browse the repository at this point in the history
  - enable availability_zones, to be able to select less than the full set of available zones (say, for do2-gov, where we had 2 but now they have
    3 zones).
  - fix up the cidr math
  - this drops a new variables.subnets.tf for the examples, to include the optional availability_zones
  - as we are nearing completion with updating all of the vpc code to TF 1.x, this should not be a problem, and it really only applies in do2-gov
  • Loading branch information
badra001 committed Apr 11, 2023
1 parent 06bed40 commit 57eafe8
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 18 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -283,3 +283,11 @@
- created to be applied in an account where a PHZ is maintained but shared to other accounts and VPCs. This will be used by
the dynamic route53 lambda to assume this role to enter the route53 records
- must be done after addition to organization

* 2.8.1 -- 2023-04-10
- subnets:
- enable availability_zones, to be able to select less than the full set of available zones (say, for do2-gov, where we had 2 but now they have
3 zones).
- fix up the cidr math
- this drops a new variables.subnets.tf for the examples, to include the optional availability_zones
- as we are nearing completion with updating all of the vpc code to TF 1.x, this should not be a problem, and it really only applies in do2-gov
36 changes: 18 additions & 18 deletions examples/full-setup-tf-upgrade/variables.subnets.tf
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@
variable "public_subnets" {
description = "List of objects with public subnet information to be created"
type = list(object({
base_cidr = string
label = string
bits = number
offset = optional(number, 0)
private = bool
tags = map(string)
enabled = optional(bool, true)
availability_zone = optional(string)
base_cidr = string
label = string
bits = number
offset = optional(number, 0)
private = bool
tags = map(string)
enabled = optional(bool, true)
availability_zone = optional(string)
availability_zones = optional(list(string), [])
# subnets = list(string)
# labels = list(string)
# availability_zones = list(string)
}))
default = []
}
Expand All @@ -21,17 +21,17 @@ variable "public_subnets" {
variable "private_subnets" {
description = "List of objects with private subnet information to be created"
type = list(object({
base_cidr = string
label = string
bits = number
offset = optional(number, 0)
private = bool
tags = map(string)
enabled = optional(bool, true)
availability_zone = optional(string)
base_cidr = string
label = string
bits = number
offset = optional(number, 0)
private = bool
tags = map(string)
enabled = optional(bool, true)
availability_zone = optional(string)
availability_zones = optional(list(string), [])
# subnets = list(string)
# labels = list(string)
# availability_zones = list(string)
}))
default = []
}

0 comments on commit 57eafe8

Please sign in to comment.