-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
82 additions
and
0 deletions.
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /aws/info/ @terraform/reviewers-accounts |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| --- | ||
| name: Bug report | ||
| about: Create a report to help us improve | ||
| title: '' | ||
| labels: bug | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| **Describe the bug** | ||
| A clear and concise description of what the bug is. | ||
|
|
||
| **Identify Environment** | ||
| - Terraform version [`terraform -version`]: | ||
| - Repository [`git remote -v show`]: | ||
| - Git branch [`git branch`]: | ||
| - Current working directory [`pwd`]: | ||
| - Commands issued | ||
| - Errors generated | ||
|
|
||
| **Expected behavior** | ||
| A clear and concise description of what you expected to happen. | ||
|
|
||
| **Screenshots** | ||
| If applicable, add pasted text output from terraform plan or apply (or a screenshot, but text is preferred) to help explain your problem. | ||
|
|
||
| **Server (please complete the following information):** | ||
| - Hostname [e.g. redwood.cto.census.gov] | ||
| - OS Version [e.g. RHEL6, RHEL7] | ||
|
|
||
| **Additional context** | ||
| Add any other context about the problem here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| <!--- template 1.0.2 ---> | ||
| <!--- Provide a general summary of your changes in the Title above --> | ||
| <!--- Incomplete PRs will be rejected and changes requested --> | ||
|
|
||
| ## Description | ||
| <!--- Describe your changes in detail --> | ||
|
|
||
| ## Purpose | ||
| <!--- Why is this change required? What problem does it solve? --> | ||
| <!--- If it fixes an open issue, please link to the issue here. --> | ||
|
|
||
|
|
||
| ## Add tf-plan output Here | ||
| - Upload the unedited `tf-plan` log (found with: ls logs/plan.*.log | tail -n 1) as markdown with syntax highlighting using `console`. | ||
| - If the plan is long, also paste here a plan summary from `tf-plan summary` | ||
| - Be sure to user markdown syntax highlighthing for script | ||
|
|
||
| ## Screenshots (if appropriate): | ||
|
|
||
| <!--- Delete the remainder of this content from here to the end before submitting the PR --> | ||
|
|
||
| ## Requirements | ||
| - Testing | ||
| 1. Be sure you have a successful ouput from `tf-plan`, and if necessary for a multi-step configuration, `tf-plan -target=...`. | ||
| 1. Post (append) the `tf-plan` log | ||
| 1. Commit/Push/PR before applying | ||
|
|
||
| - Environment Checks | ||
| <!--- follow how-to at https://gitlab.e.it.census.gov/terraform/support/blob/master/docs/howto-app-setup.md --> | ||
| 1. Make sure `remote_state.yml` is accurate | ||
| 1. Setup: `tf-directory-setup.py -l none` | ||
| 1. Setup: setup-new-directory.sh | ||
| 1. Make sure to have run `tf-directory-setup.py -l s3' after applying and then PR again to get the link | ||
|
|
||
| - Code Checks | ||
| 1. No hardcoded resource values (i.e., vpc_id = "vpc-12345678") | ||
| 1. Proper case and no spaces in Tags | ||
| 1. Resource have tags if they support them | ||
| 1. `variables` definitions include `description` and `type` | ||
| 1. Run `tf-fmt` to format the code | ||
| 1. Run `terraform-docs .` to generate updated README.md | ||
|
|
||
| - Include Documentation | ||
| 1. Be sure to have copied documentation referenced [here](https://gitlab.e.it.census.gov/terraform/support/blob/master/docs/app-setup.md) and populated | ||
| - [terraform-docs.yml](https://gitlab.e.it.census.gov/terraform/support/blob/master/docs/app-setup/.terraform-docs.yml) | ||
| - [README.md](https://gitlab.e.it.census.gov/terraform/support/blob/master/docs/app-setup/README.md.example) | ||
| 1. Include Remedy ticket numbers, CRF links, contact names, and a description in the README.md. | ||
|
|
||
| <!--- borrowed from https://github.com/stevemao/github-issue-templates/blob/master/questions-answers/PULL_REQUEST_TEMPLATE.md --> |