Skip to content

Modify Future Configuration and Links sections #215

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

marti926
Copy link
Contributor

No description provided.

@@ -59,10 +59,70 @@ module.config.data.template_file.splunk_configrules
We will centralize the AWS Config setup to send all Config events to the organization's logging account (see [main](README.md)).
This involves:

* delegation from the org management account to the logging account of the config service
* other things
* Delegation from the org management account to the logging account of the config service (each organization sectools account i.e. ent-ew-sectools : 282958839025)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not the logging account, but the security account (my original mistake), and it is for the config service

Delegation from the org management account to the security account for the config service (each organization sectools account i.e. ent-ew-sectools : 282958839025)

Comment on lines 67 to 72
# Proposed Resources
## Infrastructure
aws_config_configuration_aggregator.organization - "OIS-Config-Organizations-Aggregator"
aws_config_configuration_recorder.ois_config_recorder
aws_config_delivery_channel.config_ois_tools
aws_config_configuration_recorder_status.config_ois_tools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for an "ois"prefix, these woudl be an 'inf" prefix as they are part of the infrastructure (or INF in the name). Use inf_config for the resource name for all 4 of these. No need to have diff names.

Comment on lines +107 to +108
* Need to remove configuration recorders and Config Delivery Channels in each account and each region as they will no longer be leveraged in this configuration
* Should only include Global Config resource types in one region per organizational structure, this will pull in a vast amount of data and should not be included across all regions (will incur large data costs unnecessarily)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will this mean for each account/region? Look over the config module used as part of the baseline ("git@github.e.it.census.gov:terraform-modules/aws-inf-setup.git//config?ref=tf-upgrade").

Does this mean we will not be able to look at Config in a per account basis?

Comment on lines 116 to 124
[AWS Organizations, AWS Config, and Terraform | AWS Cloud Operations & Migrations Blog](https://aws.amazon.com/blogs/mt/aws-organizations-aws-config-and-terraform/)

[Moving from a single account AWS Config deployment to an Organization wide deployment | AWS Cloud Operations & Migrations Blog](https://aws.amazon.com/blogs/mt/moving-from-a-single-account-aws-config-deployment-to-an-organization-wide-deployment/)

[aws_config_organization_managed_rule | Resources | hashicorp/aws | Terraform | Terraform Registry](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/config_organization_managed_rule.html)

[multi-region-org-config-rules-terraform/administrator_account/config/config.tf at master · aws-samples/multi-region-org-config-rules-terraform](https://github.com/aws-samples/multi-region-org-config-rules-terraform/blob/master/administrator_account/config/config.tf)

[terraform-modules/aws-inf-setup: AWS Infrastructure Setup](https://github.e.it.census.gov/terraform-modules/aws-inf-setup)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make these a list (prefix with - or *).

Copy link
Contributor

@badra001 badra001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants