start of gliffy #232
Merged
start of gliffy #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badra001
reviewed
Mar 14, 2025
| # Capture tags for exclusion check | ||
| tags = {tag['Key']: tag['Value'] for tag in instance.get('Tags', [])} | ||
|
|
||
| resources["ec2_instances"].append({ |
There was a problem hiding this comment.
add the private ip (v4) to this please
badra001
reviewed
Mar 14, 2025
| # Capture tags for exclusion check | ||
| tags = {tag['Key']: tag['Value'] for tag in instance.get('Tags', [])} | ||
|
|
||
| resources["ec2_instances"].append({ |
badra001
reviewed
Mar 14, 2025
| logger.warning(f"Error getting tags for RDS instance {instance['DBInstanceIdentifier']}: {tag_e}") | ||
|
|
||
| resources["rds_instances"].append({ | ||
| "id": instance['DBInstanceIdentifier'], |
There was a problem hiding this comment.
add rds dns name here (and below in the Next processing)
badra001
reviewed
Mar 14, 2025
| # Capture tags for exclusion check | ||
| cluster_tags = cluster_info['cluster'].get('tags', {}) | ||
|
|
||
| resources["eks_clusters"].append({ |
There was a problem hiding this comment.
add eks version if possible (here and below)
badra001
reviewed
Mar 14, 2025
|
|
||
| return resources | ||
|
|
||
| def shutdown_ec2_instances(credentials, instances, account_id): |
There was a problem hiding this comment.
for the output in skipping, add the Name tag
badra001
reviewed
Mar 14, 2025
| timestamp = datetime.datetime.now().isoformat() | ||
|
|
||
| # Tag the instance before stopping | ||
| logger.info(f"Tagging EC2 instance {instance['id']} with {STOP_TAG}={timestamp}") |
There was a problem hiding this comment.
add Name tag value to the log
badra001
reviewed
Mar 14, 2025
| ) | ||
|
|
||
| # Stop the instance | ||
| logger.info(f"Stopping EC2 instance {instance['id']} in region {region}") |
There was a problem hiding this comment.
add Name tag and ip to this log line
badra001
reviewed
Mar 14, 2025
Comment on lines
524
to
542
| logger.info(f"Saving original ASG {asg_name} sizes: min={current_min_size}, desired={current_desired_size}") | ||
| autoscaling_client.create_or_update_tags( | ||
| Tags=[ | ||
| { | ||
| 'ResourceId': asg_name, | ||
| 'ResourceType': 'auto-scaling-group', | ||
| 'Key': TAG_KEY_ORIGINAL_MIN_SIZE, | ||
| 'Value': str(current_min_size), | ||
| 'PropagateAtLaunch': False | ||
| }, | ||
| { | ||
| 'ResourceId': asg_name, | ||
| 'ResourceType': 'auto-scaling-group', | ||
| 'Key': TAG_KEY_ORIGINAL_DESIRED_SIZE, | ||
| 'Value': str(current_desired_size), | ||
| 'PropagateAtLaunch': False | ||
| } | ||
| ] | ||
| ) |
badra001
requested changes
Mar 14, 2025
badra001
approved these changes
Sep 30, 2025
added 2 commits
September 30, 2025 14:52
|
moving forward |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can collaborate via comments.